Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

chore: adapted CLI to newest state of APISet in go-utils #6655

Merged
merged 1 commit into from Jan 24, 2022

Conversation

warber
Copy link
Contributor

@warber warber commented Jan 21, 2022

This PR contains the code adaptations for CLI to be compatible with the newest codebase in go-utils see: keptn/go-utils#378

@warber warber requested a review from a team as a code owner January 21, 2022 13:37
Signed-off-by: warber <bernd.warmuth@dynatrace.com>
@warber warber force-pushed the cli/adapt-code-to-current-go-utils branch from 0047504 to fc3ffde Compare January 21, 2022 13:39
@sonarcloud
Copy link

sonarcloud bot commented Jan 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.7% 10.7% Duplication

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #6655 (fc3ffde) into master (a3ad118) will not change coverage.
The diff coverage is 64.28%.

@@           Coverage Diff           @@
##           master    #6655   +/-   ##
=======================================
  Coverage   56.77%   56.77%           
=======================================
  Files         496      496           
  Lines       28342    28342           
  Branches     1301     1301           
=======================================
  Hits        16092    16092           
  Misses      11042    11042           
  Partials     1208     1208           
Impacted Files Coverage Δ
cli/cmd/delete_service.go 13.51% <0.00%> (ø)
cli/cmd/generate_support_archive.go 12.34% <0.00%> (ø)
cli/cmd/secret.go 76.06% <0.00%> (ø)
cli/cmd/sequencecontrol.go 0.00% <0.00%> (ø)
cli/cmd/upgrade.go 31.10% <0.00%> (ø)
cli/internal/api.go 0.00% <0.00%> (ø)
cli/cmd/add_resource.go 54.95% <50.00%> (ø)
cli/cmd/trigger_evaluation.go 60.37% <50.00%> (ø)
cli/cmd/authenticator.go 58.46% <100.00%> (ø)
cli/cmd/configure_monitoring.go 39.58% <100.00%> (ø)
... and 14 more
Flag Coverage Δ
cli 42.12% <64.28%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warber warber merged commit f86774d into master Jan 24, 2022
@warber warber deleted the cli/adapt-code-to-current-go-utils branch January 24, 2022 08:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants