Navigation Menu

Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

feat(lighthouse-service): Adapt readiness probe of lighthouse service to consider nats subscription #7735

Merged
merged 5 commits into from May 16, 2022

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented May 13, 2022

…to consider nats subscription

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl changed the title feat(lighthouse-service) Adapt readiness probe of lighthouse service to consider nats subscription feat(lighthouse-service): Adapt readiness probe of lighthouse service to consider nats subscription May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #7735 (7558fde) into master (b2ad6ad) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7735      +/-   ##
==========================================
- Coverage   59.91%   59.86%   -0.06%     
==========================================
  Files         562      562              
  Lines       32930    32936       +6     
  Branches     1590     1599       +9     
==========================================
- Hits        19730    19717      -13     
- Misses      11901    11917      +16     
- Partials     1299     1302       +3     
Impacted Files Coverage Δ
lighthouse-service/event_handler/common.go 56.12% <100.00%> (+0.57%) ⬆️
...-service/event_handler/start_evaluation_handler.go 72.25% <100.00%> (+0.14%) ⬆️
...s/ktb-approval-item/ktb-approval-item.component.ts 40.00% <0.00%> (-20.00%) ⬇️
...ce-tasks-list/ktb-sequence-tasks-list.component.ts 40.00% <0.00%> (-12.31%) ⬇️
...omponents/ktb-task-item/ktb-task-item.component.ts 54.00% <0.00%> (-6.00%) ⬇️
...b-deployment-list/ktb-deployment-list.component.ts 54.71% <0.00%> (-5.67%) ⬇️
bridge/client/app/_utils/form.utils.ts 93.75% <0.00%> (-0.99%) ⬇️
...project-settings/ktb-project-settings.component.ts 79.09% <0.00%> (-0.57%) ⬇️
...b-evaluation-info/ktb-evaluation-info.component.ts 83.13% <0.00%> (-0.40%) ⬇️
...ews/ktb-service-view/ktb-service-view.component.ts 93.00% <0.00%> (-0.07%) ⬇️
... and 6 more
Flag Coverage Δ
api 88.35% <ø> (ø)
approval-service 64.61% <ø> (ø)
bridge-server 67.62% <ø> (ø)
bridge2 73.74% <ø> (-0.27%) ⬇️
cli 43.04% <ø> (ø)
configuration-service 9.17% <ø> (ø)
distributor 70.75% <ø> (ø)
helm-service 49.07% <ø> (ø)
jmeter-service 25.29% <ø> (ø)
lighthouse-service 72.95% <100.00%> (+0.08%) ⬆️
mongodb-datastore 58.10% <ø> (ø)
remediation-service 79.77% <ø> (ø)
resource-service 81.37% <ø> (ø)
secret-service 82.53% <ø> (ø)
shipyard-controller 60.71% <ø> (ø)
statistics-service 59.29% <ø> (ø)
webhook-service 83.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label May 13, 2022
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl marked this pull request as ready for review May 13, 2022 08:23
@bacherfl bacherfl requested a review from a team as a code owner May 13, 2022 08:23
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit 51837d7 into master May 16, 2022
@bacherfl bacherfl deleted the feat/7613-lighthouse-svc-readiness branch May 16, 2022 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants