Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(bridge): Fix relative weight calculation (#9099) #9114

Merged
merged 2 commits into from Nov 7, 2022

Conversation

Kirdock
Copy link
Contributor

@Kirdock Kirdock commented Nov 7, 2022

Backport of #9099

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #9114 (1eb829a) into 0.19.x (b5fa4bf) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           0.19.x    #9114      +/-   ##
==========================================
- Coverage   70.32%   70.32%   -0.01%     
==========================================
  Files         622      622              
  Lines       32940    32945       +5     
  Branches     1725     1726       +1     
==========================================
+ Hits        23165    23168       +3     
- Misses       8535     8537       +2     
  Partials     1240     1240              
Impacted Files Coverage Δ
...uation-details/ktb-evaluation-details.component.ts 100.00% <ø> (ø)
...ktb-sli-breakdown/ktb-sli-breakdown.component.html 100.00% <ø> (ø)
...s/ktb-sli-breakdown/ktb-sli-breakdown.component.ts 93.65% <60.00%> (-1.44%) ⬇️
bridge/shared/models/result-types.ts 100.00% <100.00%> (ø)
Flag Coverage Δ
bridge-server 73.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

* fix(bridge): Fix relative weight calculation

Signed-off-by: gilbert.tanner <gilbert.tanner@dynatrace.com>

* Fixed formatting issues

Signed-off-by: gilbert.tanner <gilbert.tanner@dynatrace.com>

Signed-off-by: gilbert.tanner <gilbert.tanner@dynatrace.com>

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@Kirdock Kirdock force-pushed the backport/9083/fix-relative-weight-calculation branch from 2e5d53d to 5a4d275 Compare November 7, 2022 09:22
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thisthat
Copy link
Member

thisthat commented Nov 7, 2022

Would it make sense also to add a test that covers the usage of getRelativeSliWeight?

@Kirdock
Copy link
Contributor Author

Kirdock commented Nov 7, 2022

Would it make sense also to add a test that covers the usage of getRelativeSliWeight?

Yes, but then we would need anoher backport to the main branch. This change is something that should have been considered in the original PR.

1 similar comment
@Kirdock
Copy link
Contributor Author

Kirdock commented Nov 7, 2022

Would it make sense also to add a test that covers the usage of getRelativeSliWeight?

Yes, but then we would need anoher backport to the main branch. This change is something that should have been considered in the original PR.

@thisthat
Copy link
Member

thisthat commented Nov 7, 2022

Fair point, this would violate the cherry-picking. Therefore, I would suggest that it is not needed for this PR

@thisthat thisthat merged commit bd55bb3 into 0.19.x Nov 7, 2022
@thisthat thisthat deleted the backport/9083/fix-relative-weight-calculation branch November 7, 2022 12:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants