Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix(bridge): Fixed prefix path #9497

Merged
merged 3 commits into from Feb 7, 2023
Merged

fix(bridge): Fixed prefix path #9497

merged 3 commits into from Feb 7, 2023

Conversation

Kirdock
Copy link
Contributor

@Kirdock Kirdock commented Feb 6, 2023

Fixes #9496
Also adds the prefix to some endpoints in the api-gateway-nginx configuration where it was missing

Signed-off-by: Klaus Strießnig k.striessnig@gmail.com

Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #9497 (d592d9d) into master (09fbce1) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9497   +/-   ##
=======================================
  Coverage   70.94%   70.94%           
=======================================
  Files         618      618           
  Lines       32700    32705    +5     
  Branches     1643     1645    +2     
=======================================
+ Hits        23200    23204    +4     
  Misses       8257     8257           
- Partials     1243     1244    +1     
Impacted Files Coverage Δ
bridge/client/app/_utils/app.utils.ts 92.00% <75.00%> (-1.48%) ⬇️
bridge/client/app/app.module.ts 100.00% <100.00%> (ø)
distributor/pkg/uniform/log/uniformlog.go 71.87% <0.00%> (-4.69%) ⬇️
cli/pkg/config/cli_config.go 59.75% <0.00%> (+3.65%) ⬆️
Flag Coverage Δ
api 75.56% <ø> (ø)
approval-service 64.34% <ø> (ø)
bridge-server 74.33% <ø> (ø)
bridge2 87.28% <83.33%> (-0.01%) ⬇️
cli 44.71% <ø> (+0.06%) ⬆️
distributor 69.88% <ø> (-0.30%) ⬇️
lighthouse-service 72.89% <ø> (ø)
mongodb-datastore 58.25% <ø> (ø)
remediation-service 100.00% <ø> (ø)
resource-service 77.42% <ø> (ø)
secret-service 81.35% <ø> (ø)
shipyard-controller 68.07% <ø> (ø)
statistics-service 58.41% <ø> (ø)
webhook-service 84.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Kirdock Kirdock marked this pull request as ready for review February 6, 2023 16:24
@Kirdock Kirdock added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Feb 7, 2023
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@Kirdock Kirdock requested a review from a team as a code owner February 7, 2023 09:46
Signed-off-by: Klaus Strießnig <k.striessnig@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kirdock

@Kirdock Kirdock merged commit d7e31c1 into master Feb 7, 2023
@Kirdock Kirdock deleted the fix/9496/fix-prefix-path branch February 7, 2023 15:21
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge: Prefix-path does not work with the bridge client
3 participants