-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use helm charts instead of manifests + document KeptnConfig CRD #747
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
- Coverage 57.81% 57.07% -0.74%
==========================================
Files 122 104 -18
Lines 10095 9014 -1081
==========================================
- Hits 5836 5145 -691
+ Misses 4051 3694 -357
+ Partials 208 175 -33
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. I left a few editorial suggestions and one structural suggestion for your consideration.
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com
Fixes: #597
PLEASE do not merge this until we do not have a first version of helm-charts released