Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scheduler): improve logging #2283

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

geoffrey1330
Copy link
Member

fixes #1880

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330 geoffrey1330 requested a review from a team as a code owner October 17, 2023 14:05
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 47bfbb5
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/652e94b3febc3c0007df5fb8
😎 Deploy Preview https://deploy-preview-2283--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2283 (18d575a) into main (286e38b) will increase coverage by 1.17%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2283      +/-   ##
==========================================
+ Coverage   85.63%   86.80%   +1.17%     
==========================================
  Files         161      101      -60     
  Lines       10239     6702    -3537     
==========================================
- Hits         8768     5818    -2950     
+ Misses       1195      739     -456     
+ Partials      276      145     -131     
Files Coverage Δ
scheduler/pkg/klcpermit/permit.go 0.00% <ø> (ø)
scheduler/pkg/klcpermit/workflow_manager.go 65.57% <ø> (+0.53%) ⬆️

... and 61 files with indirect coverage changes

Flag Coverage Δ
certificate-operator ?
lifecycle-operator 85.45% <ø> (ø)
metrics-operator ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
RealAnna
RealAnna previously approved these changes Oct 17, 2023
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@odubajDT odubajDT merged commit 59fa565 into keptn:main Oct 18, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging in Controllers by adding relevant context
4 participants