Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing namespace to app CRD reference page #2629

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Dec 4, 2023

Description

This PR adds the missing namespace field to the KeptnApp CRD reference page.

Fixes #1717

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies requested a review from a team as a code owner December 4, 2023 12:32
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 4, 2023
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 6ca8623
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/656dc6da698a09000813e8fe
😎 Deploy Preview https://deploy-preview-2629--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mowies mowies merged commit 1d940b6 into keptn:main Dec 4, 2023
14 checks passed
@mowies mowies deleted the docs-app-ns branch December 4, 2023 13:11
ahmedavid pushed a commit to ahmedavid/lifecycle-toolkit that referenced this pull request Dec 6, 2023
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: David Ahmadov <ahmedavid@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document missing namespace field for KeptnApp reference page
4 participants