Features/erb templates #9

Closed
wants to merge 23 commits into
from

Conversation

Projects
None yet
2 participants

rochgs commented Dec 15, 2011

What i did

Now snippets can render erb files in place of its body. Usage is described in readme.md:

"Snippets search for templates in RAILS_VIEWS_PATH/shared/snippets. The snippet searchs for a file with its same name but with all non A-Za-z0-9 characters changed to underscores. If this file exists, snippet html body is ignored and the template is rendered in its place".

So I have updated readme.md too, TODO lists included :)

What I didn't do

I didn''t change versión numbers or any other identification data from the gem.

rochgs added some commits Aug 31, 2011

Merge branch 'features/attaching_to_page_parts' into features/erb_tem…
…plates

Conflicts:
	lib/extensions/page_extensions.rb
Moved rendering of snippets templates from model to PagesController
(through an after_filter). Now render has access to request which is
needed for some complex logic like cells.
Merge branch 'features/attaching_to_page_parts' into features/erb_tem…
…plates

Conflicts:
	lib/extensions/page_extensions.rb
Code in Extensions::PagesController hast to be placed directly in
PagesController while trying to solve overriding problem.
Merge branch 'features/attaching_to_page_parts' into features/erb_tem…
…plates

Conflicts:
	lib/extensions/page_extensions.rb
	lib/refinerycms-snippets.rb
Moved rendering of snippets templates from Extentions::PagesController
to Extensions::PagesHelper. This way it's less intrusive with
Refinery.
Owner

keram commented Jan 16, 2012

Thank you for your great work!
And I apologize to you for big lag, because i couldn't work and I wasn't online..

I try this review soon as possible but it may take awhile for compatibility with branch 3-1.

@rochgs rochgs closed this Jun 12, 2013

@rochgs rochgs referenced this pull request Feb 27, 2012

Merged

ERB templates for Rails 3 1 #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment