Support non-tensorflow backends in KerasCV's preprocessing layers #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR Tirth! LGTM! Please rebase with master as some of the errors have been resolved in master. |
divyashreepathihalli
approved these changes
Dec 14, 2023
|
LGTM! Thanks :)! |
yuvraj-wale
pushed a commit
to yuvraj-wale/keras-cv
that referenced
this pull request
Feb 8, 2024
…ras-team#2240) * Support non-TF backends in KerasCV's preprocessing layers * Fix failing PyTorch tests on GPU * ops.convert_to_tensor -> ops.convert_to_numpy * Fix remaining instances * More torch failures * Remove unrelated change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for non-tensorflow backends in KerasCV's preprocessing layers. When not working with TensorFlow specific data structures (raggeds and sparse tensors), the preprocessing layers now accept and return backend native tensors.
Note that all the computations still happen in TensorFlow and it would require a major refactor to change that.
For the TensorFlow backend, the changes in this PR should be a no-op i.e. the behaviour should remain completely unchanges for the tensorflow backend.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.