Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate VGG16 from legacy to backbone #2341

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

pranavvp16
Copy link
Contributor

@pranavvp16 pranavvp16 commented Feb 11, 2024

I have migrated the VGG16 architecture from legacy to backbone in keras_cv. Here is the notebook that compares the legacy and migrated model implementation. #2339 .
closes: #2339

@divyashreepathihalli
Copy link
Collaborator

Amazing!! Thanks @pranavvp16 we will take a look!

Copy link
Collaborator

@divyashreepathihalli divyashreepathihalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Feb 12, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 12, 2024
@sampathweb
Copy link
Collaborator

@pranavvp16 - Looks like we need to run bash shell/lint.sh to sort the imports. Once its done, the CI should be happy and we can merge the PR.

@pranavvp16
Copy link
Contributor Author

@sampathweb made the changes. The CI should be happy now!

@sampathweb
Copy link
Collaborator

LGTM. @divyashreepathihalli - I am good to merge.

@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Feb 21, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 21, 2024
@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Feb 22, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 22, 2024
@divyashreepathihalli divyashreepathihalli merged commit cc450d7 into keras-team:master Feb 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate vgg16 from legacy to backbone
4 participants