From 8ab38f8dd51a5bcff21caafa0937c2e87188a821 Mon Sep 17 00:00:00 2001 From: Jonathan Bischof Date: Tue, 21 Mar 2023 22:04:09 +0000 Subject: [PATCH 1/5] Init _backbone in Task --- keras_nlp/models/task.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/keras_nlp/models/task.py b/keras_nlp/models/task.py index 8ea1e2439a..83482378de 100644 --- a/keras_nlp/models/task.py +++ b/keras_nlp/models/task.py @@ -25,7 +25,11 @@ @keras.utils.register_keras_serializable(package="keras_nlp") class Task(PipelineModel): """Base class for Task models.""" - + + def __init__(self, *args, **kwargs): + self._backbone = None + super().__init__(*args, **kwargs) + def preprocess_samples(self, x, y=None, sample_weight=None): return self.preprocessor(x, y=y, sample_weight=sample_weight) From 4b99e2a3aa8976e1349195fe1860bffbb4675358 Mon Sep 17 00:00:00 2001 From: Jonathan Bischof Date: Tue, 21 Mar 2023 22:10:17 +0000 Subject: [PATCH 2/5] Fix `preprocessor` as well --- keras_nlp/models/task.py | 1 + 1 file changed, 1 insertion(+) diff --git a/keras_nlp/models/task.py b/keras_nlp/models/task.py index 83482378de..170b553455 100644 --- a/keras_nlp/models/task.py +++ b/keras_nlp/models/task.py @@ -28,6 +28,7 @@ class Task(PipelineModel): def __init__(self, *args, **kwargs): self._backbone = None + self._preprocessor = None super().__init__(*args, **kwargs) def preprocess_samples(self, x, y=None, sample_weight=None): From 9ebe8b5e90fcf07ec518ca953087c10ac183ffc8 Mon Sep 17 00:00:00 2001 From: Jonathan Bischof Date: Tue, 21 Mar 2023 22:11:30 +0000 Subject: [PATCH 3/5] format --- keras_nlp/models/task.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/keras_nlp/models/task.py b/keras_nlp/models/task.py index 170b553455..9cb5a483d3 100644 --- a/keras_nlp/models/task.py +++ b/keras_nlp/models/task.py @@ -25,12 +25,12 @@ @keras.utils.register_keras_serializable(package="keras_nlp") class Task(PipelineModel): """Base class for Task models.""" - + def __init__(self, *args, **kwargs): self._backbone = None self._preprocessor = None super().__init__(*args, **kwargs) - + def preprocess_samples(self, x, y=None, sample_weight=None): return self.preprocessor(x, y=y, sample_weight=sample_weight) From 2b1848c3a99feeb9232fe0f4b448144dcef15b6c Mon Sep 17 00:00:00 2001 From: Jonathan Bischof Date: Tue, 21 Mar 2023 23:08:50 +0000 Subject: [PATCH 4/5] Fix `_tokenizer` --- keras_nlp/models/preprocessor.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/keras_nlp/models/preprocessor.py b/keras_nlp/models/preprocessor.py index 546cc7639b..5e264997da 100644 --- a/keras_nlp/models/preprocessor.py +++ b/keras_nlp/models/preprocessor.py @@ -22,6 +22,10 @@ class Preprocessor(keras.layers.Layer): """Base class for model preprocessors.""" + def __init__(self, *args, **kwargs): + self._tokenizer = None + super().__init__(*args, **kwargs) + @property def tokenizer(self): """The tokenizer used to tokenize strings.""" From 4bcad557e9e6c7afeb034116579dcad3f0dd5a1a Mon Sep 17 00:00:00 2001 From: Jonathan Bischof Date: Wed, 22 Mar 2023 00:51:23 +0000 Subject: [PATCH 5/5] Chain to super() first --- keras_nlp/models/preprocessor.py | 2 +- keras_nlp/models/task.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/keras_nlp/models/preprocessor.py b/keras_nlp/models/preprocessor.py index 5e264997da..70b2e72b70 100644 --- a/keras_nlp/models/preprocessor.py +++ b/keras_nlp/models/preprocessor.py @@ -23,8 +23,8 @@ class Preprocessor(keras.layers.Layer): """Base class for model preprocessors.""" def __init__(self, *args, **kwargs): - self._tokenizer = None super().__init__(*args, **kwargs) + self._tokenizer = None @property def tokenizer(self): diff --git a/keras_nlp/models/task.py b/keras_nlp/models/task.py index 9cb5a483d3..f1497f063f 100644 --- a/keras_nlp/models/task.py +++ b/keras_nlp/models/task.py @@ -27,9 +27,9 @@ class Task(PipelineModel): """Base class for Task models.""" def __init__(self, *args, **kwargs): + super().__init__(*args, **kwargs) self._backbone = None self._preprocessor = None - super().__init__(*args, **kwargs) def preprocess_samples(self, x, y=None, sample_weight=None): return self.preprocessor(x, y=y, sample_weight=sample_weight)