Correct typo mistake in neural_machine_translation_with_transformer.py #1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at Line No.157 it mentioned: `encoder_inputs` is the vectorized source sentence and `encoder_inputs` is the target sentence "so far", Actually the target sentence "so far" , should be `decoder_inputs` instead of `encoder_inputs` Corrected the same.
At this Line No.157 in neural_machine_translation_with_transformer.py, it was mentioned: encoder_inputs is the vectorized source sentence and encoder_inputs is the target sentence "so far", Actually the target sentence "so far" , should be decoder_inputs instead of encoder_inputs Corrected the same in .md file also.
At Line No.157 in neural_machine_translation_with_transformer.py, it was mentioned: encoder_inputs is the vectorized source sentence and encoder_inputs is the target sentence "so far", Actually the target sentence "so far" , should be decoder_inputs instead of encoder_inputs Corrected the same in .ipynb file also.
pcoet
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Line No.157 in neural_machine_translation_with_transformer.py, it was mentioned:
Actually
the target sentence "so far", should bedecoder_inputsinstead ofencoder_inputsCorrected the same.
Shall fix #1002