New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushBullet IO implementation #139

Merged
merged 6 commits into from Mar 23, 2018

Conversation

Projects
None yet
2 participants
@gianricod
Copy link
Member

gianricod commented Mar 22, 2018

Hi @cedricve

I have tested this implementation and it seems to work.
Let me knnow if i need to polish anything

@cedricve

This comment has been minimized.

Copy link

cedricve commented on d9563f1 Feb 7, 2018

awesome @gianricod, are you planning to merge this upstream?

This comment has been minimized.

Copy link
Owner

gianricod replied Feb 10, 2018

Hi @cedricve

I see you have that feature in the cloud so I was not sure if you wanted it.
If you want i can merge it. But first it needs some better functionalities.
At this stage it just sends a message. It was for my personal use .
It would be nice to send an image as well.

if you want I can pick up where i left and then merge it.

This comment has been minimized.

Copy link

cedricve replied Feb 10, 2018

hey @gianricod, indeed well I don't mind to integrate this. It looks good so far!
It will require 2 posts (1 uploading the image, 2 sending the event).
https://stackoverflow.com/questions/28917968/python-and-pushbullet-api-send-a-file

This comment has been minimized.

Copy link
Owner

gianricod replied Mar 5, 2018

Hi @cedricve
I had some time and made some progress but i need your help for step 1.

See here :

* Step 1 : save file to tmp and provide path in a string var

I need you to add the code for step 1 .
Up to you how you do that as far as in the end tmpFile is the path of the image to send.

gianrico

This comment has been minimized.

Copy link

cedricve replied Mar 7, 2018

hey @gianricod, awesome! looks like i've missed this. Hmm what you actually need to do is something similar like this class.

https://github.com/gianricod/machinery/blob/master/src/kerberos/machinery/io/FileManager.cpp#L64

Let me know if you need more help.
Amazing work!
Cédric

gianricod added some commits Mar 5, 2018

@cedricve

This comment has been minimized.

Copy link
Member

cedricve commented Mar 23, 2018

This looks great @gianricod, and it build succesfully. I'll check it out today, merging already in develop branch.

@cedricve cedricve merged commit e03ce89 into kerberos-io:develop Mar 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cedricve

This comment has been minimized.

Copy link
Member

cedricve commented Mar 31, 2018

Will be integrated in 2.6.1 in advanced settings. Thanks @gianricod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment