make sure we build a 64 bits enabled platform on Darwin #11

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

benoitc commented Oct 8, 2011

This patch detect if 64 bits is supported and build erlang accordingly.

Collaborator

yrashk commented Oct 8, 2011

@thomasc, what do you think? Shouldn't we allow building 32-bit VM as well (for example, for those who need to use wx)?

benoitc commented Oct 8, 2011

An option is probably better. I can add an an only_32bits option if you want.

Collaborator

yrashk commented Oct 9, 2011

This is configurable through KERL_CONFIGURE_OPTIONS even right now. However, it is not cross-platform. How about introducing a KERL_64BIT=y|n OS env var that will modify KERL_CONFIGURE_OPTIONS to either enable or disable 64 bits in a cross-platform fashion?

Contributor

thomasc commented Oct 11, 2011

The problem I see here is that the otp_build script itself is not designed in a cross-platform fashion, and not particularly consistent.
For the time being it's always possible to define host specific flags in the .kerlrc file.

Collaborator

yrashk commented Oct 11, 2011

@thomasc, what do you think about KERL_64BIT kerl flag that makes 64/32 compilation cross-platform?

Collaborator

yrashk commented Oct 11, 2011

Ok, so the problem is that, for example, on Linux, this setting won't make a lot of sense on non-x86 configurations.

Contributor

thomasc commented Oct 11, 2011

Indeed, we can't really cover all possible os/archs or we'll end up duplicating a lot of otp_build's logic.
That's why I think it's better to handle the case through the KERL_CONFIGURE_OPTIONS var, specially setting it once for all in the .kerlrc file for a given host.

Collaborator

mrallen1 commented Apr 6, 2016

This PR has been open for >4 years. I'm going to close it - if it's still a problem, please open a new issue.

mrallen1 closed this Apr 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment