Update kerl to use $_KERL_ACTIVE_DIR for get_active_path #60

Merged
merged 2 commits into from Jan 31, 2014

Conversation

Projects
None yet
3 participants
Contributor

jj1bdx commented Jan 28, 2014

  • Define $_KERL_ACTIVE_DIR when activating
  • Use $_KERL_ACTIVE_DIR for kerl status
  • Unset $_KERL_ACTIVE_DIR when executing kerl_deactivate

(Using $REBAR_PLT_DIR was a bad idea and didn't work so I fixed it)

@jj1bdx jj1bdx Update kerl
* Let get_active_path to use $REBAR_PLT_DIR for the current active installation path
4142e67

jj1bdx referenced this pull request Jan 28, 2014

Closed

`kerl status` does not work #59

Contributor

jj1bdx commented Jan 28, 2014

See also #59

@jj1bdx jj1bdx Update kerl
* Define $_KERL_ACTIVE_DIR when activating
* Use $_KERL_ACTIVE_DIR for `kerl status`
56035fd

@yrashk yrashk added a commit that referenced this pull request Jan 31, 2014

@yrashk yrashk Merge pull request #60 from jj1bdx/jj1bdx-active-path-fix
Update kerl to use $_KERL_ACTIVE_DIR for get_active_path
9cf83c9

@yrashk yrashk merged commit 9cf83c9 into kerl:master Jan 31, 2014

Contributor

norton commented on kerl in 56035fd Feb 1, 2014

FYI. There is a trailing whitespace on line 452.

Enabling this git config for diff works well for manually spotting such whitespace issues.

[color "diff"]
        meta = yellow bold
        frag = magenta bold
        old = red bold
        new = green bold
        whitespace = red reverse
Contributor

jj1bdx replied Feb 6, 2014

👍 for the fix. Thanks for the tips. I think my git has already been configured for it, though I often forget to erase the trailing whitespaces.

jj1bdx deleted the jj1bdx:jj1bdx-active-path-fix branch May 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment