BUG: Set flags according to docs when using `g_spawn_sync()`

They specifically say 'must set'. Also in code: https://github.com/GNOME/glib/blob/3fe6f2a44fdaa7a0e50345b66b6354e19686ff87/glib/gspawn.c#L384-L387
kernc · Jan 19, 2019 · 85325e8790e68425300be35b0a4999d5a05d9fb0 · 85325e8
1 parent 827f1e1
commit 85325e8790e68425300be35b0a4999d5a05d9fb0
Unified Split

Showing with 2 additions and 4 deletions.

+1 −1 src/events.c

+1 −3 src/exec.c
diff --git a/src/events.c b/src/events.c
@@ -211,7 +211,7 @@ is_on_ac_power ()
    // Read AC power state. Should work in most cases. See: https://bugs.debian.org/473629
    char *argv[] = {"sh", "-c", "grep -q 1 /sys/class/power_supply/*/online", NULL};
    g_spawn_sync (NULL, argv, NULL,
-  
-                  G_SPAWN_SEARCH_PATH | (IS_DEBUG ? G_SPAWN_DEFAULT : G_SPAWN_STDERR_TO_DEV_NULL),
+  
+                  G_SPAWN_SEARCH_PATH | G_SPAWN_STDOUT_TO_DEV_NULL | G_SPAWN_STDERR_TO_DEV_NULL,
                  NULL, NULL, NULL, NULL, &exit_status, NULL);
    gboolean is_ac_power = exit_status == 0;
    return is_ac_power;

diff --git a/src/exec.c b/src/exec.c
@@ -13,9 +13,7 @@ execute (char **argv,
 {
    g_autoptr (GError) err = NULL;
    gint exit_status = -1;
-  
-    GSpawnFlags flags = IS_DEBUG ?
-  
-                        G_SPAWN_DEFAULT :
-  
-                        G_SPAWN_STDOUT_TO_DEV_NULL | G_SPAWN_STDERR_TO_DEV_NULL;
+  
+    GSpawnFlags flags = G_SPAWN_STDOUT_TO_DEV_NULL | G_SPAWN_STDERR_TO_DEV_NULL;
    g_spawn_sync (NULL, argv, envp, flags | G_SPAWN_SEARCH_PATH,
                  NULL, NULL, NULL, NULL, &exit_status, &err);