Add oldest instance age metric by state#165
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hypeman_instances_oldest_in_state_secondsas an observable gauge grouped bystateandhypervisorhypeman_instances_totalcallbackTesting
go test ./lib/instances -run 'TestSnapshotCompressionMetrics_RecordAndObserve|TestInstanceOldestInStateMetric_ObserveOldestAgePerState'Note
Low Risk
Low risk: adds a read-only OpenTelemetry gauge and a unit test; behavior change is limited to metrics emission and clamps invalid/negative ages to 0.
Overview
Adds a new observable gauge,
hypeman_instances_oldest_in_state_seconds, labeled bystateandhypervisor, computed in the same callback ashypeman_instances_totalby tracking the maximum age sinceCreatedAt(with zero/negative ages ignored or clamped).Extends
metrics_test.gowith a focused test that creates multiple instances across stopped/standby states and verifies both the per-state counts and the reported oldest age values.Written by Cursor Bugbot for commit eb2bf25. This will update automatically on new commits. Configure here.