Bump image manifest resolve timeout to 5s#226
Merged
Conversation
Docker Hub manifest fetches from prod-yul intermittently exceed the 2s deadline on the registry/auth endpoints, surfacing as 500s on POST /images. Bumping to 5s to absorb the long-tail without appreciably slowing the failure path.
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: Changes are to image manifest resolution logic in lib/images/manager.go, not to API endpoints (packages/api/cmd/api/) or Temporal workflows (packages/api/lib/temporal) as specified in the filter. To monitor this PR anyway, reply with |
hiroTamada
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump the manifest-resolve context timeout in `(*manager).CreateImage` from 2s to 5s (`lib/images/manager.go:123`).
Docker Hub manifest fetches from `prod-yul` intermittently exceed the existing 2s deadline. Observed errors include:
Currently surfaces as 500 on `POST /images`. 5s is generous enough to ride out the long-tail without appreciably slowing the failure path under genuine rate-limit / down-registry conditions.
This is a stopgap — the longer-term fix is retry-with-backoff and/or a metro-local registry mirror, but those are bigger changes.
Test plan
Note
Low Risk
Low risk: only increases the
CreateImagemanifest-resolve context deadline from 2s to 5s, affecting request latency only when registries are slow.Overview
In
lib/images/manager.go, increases the manifest resolve timeout in(*manager).CreateImagefrom 2s to 5s to reduce intermittentcontext deadline exceededfailures when resolving image digests from remote registries.Reviewed by Cursor Bugbot for commit ec38e69. Bugbot is set up for automated code reviews on this repo. Configure here.