Skip to content

Bump image manifest resolve timeout to 5s#226

Merged
sjmiller609 merged 1 commit into
mainfrom
hypeship/bump-manifest-timeout-5s
May 11, 2026
Merged

Bump image manifest resolve timeout to 5s#226
sjmiller609 merged 1 commit into
mainfrom
hypeship/bump-manifest-timeout-5s

Conversation

@sjmiller609

@sjmiller609 sjmiller609 commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Bump the manifest-resolve context timeout in `(*manager).CreateImage` from 2s to 5s (`lib/images/manager.go:123`).

Docker Hub manifest fetches from `prod-yul` intermittently exceed the existing 2s deadline. Observed errors include:

Currently surfaces as 500 on `POST /images`. 5s is generous enough to ride out the long-tail without appreciably slowing the failure path under genuine rate-limit / down-registry conditions.

This is a stopgap — the longer-term fix is retry-with-backoff and/or a metro-local registry mirror, but those are bigger changes.

Test plan

  • CI green
  • Manual: `POST /images` for an existing public image succeeds within the new budget
  • Manual: `POST /images` for a bogus manifest fails fast (<5s + RTT) with the same error mapping

Note

Low Risk
Low risk: only increases the CreateImage manifest-resolve context deadline from 2s to 5s, affecting request latency only when registries are slow.

Overview
In lib/images/manager.go, increases the manifest resolve timeout in (*manager).CreateImage from 2s to 5s to reduce intermittent context deadline exceeded failures when resolving image digests from remote registries.

Reviewed by Cursor Bugbot for commit ec38e69. Bugbot is set up for automated code reviews on this repo. Configure here.

Docker Hub manifest fetches from prod-yul intermittently exceed the
2s deadline on the registry/auth endpoints, surfacing as 500s on
POST /images. Bumping to 5s to absorb the long-tail without
appreciably slowing the failure path.
@sjmiller609 sjmiller609 marked this pull request as ready for review May 11, 2026 20:39
@sjmiller609 sjmiller609 requested a review from hiroTamada May 11, 2026 20:39
@firetiger-agent

Copy link
Copy Markdown

Firetiger deploy monitoring skipped

This PR didn't match the auto-monitor filter configured on your GitHub connection:

Any PR that changes the kernel API. Monitor changes to API endpoints (packages/api/cmd/api/) and Temporal workflows (packages/api/lib/temporal) in the kernel repo

Reason: Changes are to image manifest resolution logic in lib/images/manager.go, not to API endpoints (packages/api/cmd/api/) or Temporal workflows (packages/api/lib/temporal) as specified in the filter.

To monitor this PR anyway, reply with @firetiger monitor this.

@sjmiller609 sjmiller609 merged commit 87e791a into main May 11, 2026
11 checks passed
@sjmiller609 sjmiller609 deleted the hypeship/bump-manifest-timeout-5s branch May 11, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants