Skip to content

Instrument guest exec steps#246

Merged
sjmiller609 merged 3 commits into
mainfrom
hypeship/instrument-guest-exec
Jun 1, 2026
Merged

Instrument guest exec steps#246
sjmiller609 merged 3 commits into
mainfrom
hypeship/instrument-guest-exec

Conversation

@sjmiller609

@sjmiller609 sjmiller609 commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds detailed guest.exec child spans when command execution is waiting for the guest agent to become reachable.
  • Breaks the wait path into connection lookup, exec stream open, start request send, and receive-until-exit timing.
  • Records receive-path byte counts, bytes sent, and exit code so traces can distinguish first-contact/setup cost from in-guest command runtime.
  • Keeps the no-wait exec path free of extra guest.exec.* spans.
  • Makes the Linux test subnet lock reopen an existing shared lock file safely so parallel integration tests can coordinate reliably.

Tests

  • go test ./lib/guest -count=1
  • CI: test, test-darwin, e2e-install, preview, semgrep, socket, and bugbot are passing.

@sjmiller609 sjmiller609 marked this pull request as ready for review May 29, 2026 20:58
@firetiger-agent

Copy link
Copy Markdown

Firetiger deploy monitoring skipped

This PR didn't match the auto-monitor filter configured on your GitHub connection:

PRs in the kernel, infra, hypeman, and hypeship repos. kernel is a ~mono repo with many logical services underneath, ensure to focus on the implicated service for the PR

Reason: Cannot determine repository from PR information; please clarify if this PR is in the kernel, infra, hypeman, or hypeship repo, and if in kernel, confirm the affected service.

To monitor this PR anyway, reply with @firetiger monitor this.

@sjmiller609 sjmiller609 requested a review from rgarcia May 29, 2026 20:58
@sjmiller609 sjmiller609 merged commit 97416d8 into main Jun 1, 2026
15 of 17 checks passed
@sjmiller609 sjmiller609 deleted the hypeship/instrument-guest-exec branch June 1, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants