From f322f0ca34d6ce769b3ed8b74f9b2c21e30de9cd Mon Sep 17 00:00:00 2001 From: Camila Alvarez Date: Tue, 4 Mar 2025 18:37:33 -0300 Subject: [PATCH 1/2] results: add --arch filter Adds --arch to results options and parameter filter_architecture to api params in dashboard_fetch_summary, dashboard_fetch_builds, dashboard_fetch_boots, and dashboard_fetch_tests. Signed-off-by: Camila Alvarez --- kcidev/subcommands/results.py | 42 +++++++++++++++++------------------ 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/kcidev/subcommands/results.py b/kcidev/subcommands/results.py index ae602f9..7fd3d55 100644 --- a/kcidev/subcommands/results.py +++ b/kcidev/subcommands/results.py @@ -55,47 +55,51 @@ def dashboard_api_fetch(endpoint, params, max_retries=3): raise click.Abort() -def dashboard_fetch_summary(origin, giturl, branch, commit): +def dashboard_fetch_summary(origin, giturl, branch, commit, arch): endpoint = f"tree/{commit}/summary" params = { "origin": origin, "git_url": giturl, "git_branch": branch, } - + if arch is not None: + params["filter_architecture"] = arch return dashboard_api_fetch(endpoint, params) -def dashboard_fetch_builds(origin, giturl, branch, commit): +def dashboard_fetch_builds(origin, giturl, branch, commit, arch): endpoint = f"tree/{commit}/builds" params = { "origin": origin, "git_url": giturl, "git_branch": branch, } - + if arch is not None: + params["filter_architecture"] = arch return dashboard_api_fetch(endpoint, params) -def dashboard_fetch_boots(origin, giturl, branch, commit): +def dashboard_fetch_boots(origin, giturl, branch, commit, arch): endpoint = f"tree/{commit}/boots" params = { "origin": origin, "git_url": giturl, "git_branch": branch, } - + if arch is not None: + params["filter_architecture"] = arch return dashboard_api_fetch(endpoint, params) -def dashboard_fetch_tests(origin, giturl, branch, commit): +def dashboard_fetch_tests(origin, giturl, branch, commit, arch): endpoint = f"tree/{commit}/tests" params = { "origin": origin, "git_url": giturl, "git_branch": branch, } - + if arch is not None: + params["filter_architecture"] = arch return dashboard_api_fetch(endpoint, params) @@ -439,6 +443,7 @@ def common_options(func): is_flag=True, help="Select latest results available", ) + @click.option("--arch", help="Filter by arch") @wraps(func) def wrapper(*args, **kwargs): return func(*args, **kwargs) @@ -480,20 +485,12 @@ def results(ctx): @results.command() @common_options @click.pass_context -def summary( - ctx, - origin, - git_folder, - giturl, - branch, - commit, - latest, -): +def summary(ctx, origin, git_folder, giturl, branch, commit, latest, arch): """Display a summary of results.""" giturl, branch, commit = set_giturl_branch_commit( origin, giturl, branch, commit, latest, git_folder ) - data = dashboard_fetch_summary(origin, giturl, branch, commit) + data = dashboard_fetch_summary(origin, giturl, branch, commit, arch) cmd_summary(data) @@ -521,6 +518,7 @@ def builds( branch, commit, latest, + arch, download_logs, status, filter, @@ -529,7 +527,7 @@ def builds( giturl, branch, commit = set_giturl_branch_commit( origin, giturl, branch, commit, latest, git_folder ) - data = dashboard_fetch_builds(origin, giturl, branch, commit) + data = dashboard_fetch_builds(origin, giturl, branch, commit, arch) cmd_builds(data, commit, download_logs, status) @@ -545,6 +543,7 @@ def boots( branch, commit, latest, + arch, download_logs, status, filter, @@ -553,7 +552,7 @@ def boots( giturl, branch, commit = set_giturl_branch_commit( origin, giturl, branch, commit, latest, git_folder ) - data = dashboard_fetch_boots(origin, giturl, branch, commit) + data = dashboard_fetch_boots(origin, giturl, branch, commit, arch) cmd_tests(data["boots"], commit, download_logs, status, filter) @@ -569,6 +568,7 @@ def tests( branch, commit, latest, + arch, download_logs, status, filter, @@ -577,7 +577,7 @@ def tests( giturl, branch, commit = set_giturl_branch_commit( origin, giturl, branch, commit, latest, git_folder ) - data = dashboard_fetch_tests(origin, giturl, branch, commit) + data = dashboard_fetch_tests(origin, giturl, branch, commit, arch) cmd_tests(data["tests"], commit, download_logs, status, filter) From edcecaddb1a46b5cd8aa7b7c55fa5d28bee945ee Mon Sep 17 00:00:00 2001 From: Camila Alvarez Date: Wed, 5 Mar 2025 21:37:19 -0300 Subject: [PATCH 2/2] Add documentation for arch filter Signed-off-by: Camila Alvarez --- docs/results.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/docs/results.md b/docs/results.md index c19c0fa..abf314b 100644 --- a/docs/results.md +++ b/docs/results.md @@ -132,6 +132,15 @@ Example: kci-dev results boots --giturl 'https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git' --branch master --latest --filter=filter.yaml ``` +## --arch + +Filters results by arch. + +Example: +```sh +kci-dev results summary --giturl 'https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git' --branch master --latest --arch arm64 +``` + ### without arguments If used without arguments, `kci-dev results` subcommands will get KernelCI status