Fix 'show dhcp-server' output in CLI and operational #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- firewall: allow traffic to be forwarded from lan to wan zone - dhcpv6: enable client on wan interface Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The isoformat() method already includes the timezone offset when the datetime object has timezone info. Appending "+00:00" created an invalid double-timezone suffix like "2025-11-30T13:13:49+00:00+00:00" which failed YANG validation. Error was: admin@bpi-26-60-00:/> show dhcp-server Error running sysrepocfg: Command '['sysrepocfg', '-f', 'json', '-X', '-d', 'operational', '-x', '/infix-dhcp-server:dhcp-server']' returned non-zero exit status 1. No interface data retrieved. With syslog showing: statd[4291]: libyang[0]: Invalid union value "2025-11-30T13:13:49+00:00+00:00" - no matching subtype found Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The EXPIRES column was misaligned due to multiple issues: - Column header used width 10 while data rows used width 9 - Expiry values had leading space intended for the narrower width - CLIENT ID column width (19) was too narrow for typical client IDs like "01:00:a0:85:00:01:05" (20 chars), causing overflow Fixed by using consistent width for EXPIRES, removing the leading space from expiry values, and widening CLIENT ID column to 22. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Due to their nature we cannot read out the RPM of the pwm fans on the BPi-R3. But we can at least show it's alive, or steering out a signal to the fan. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes:
show dhcp-server,factory-configfor BPi-R3 and NanoPi R2Saction: acceptfor thelan-to-wanforwarding policy, effectively preventing any forwarding from the LAN to the WAN zoneChecklist
Tick relevant boxes, this PR is-a or has-a: