Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement global/default config #46

Closed
toddnestor opened this issue May 22, 2017 · 3 comments
Closed

Implement global/default config #46

toddnestor opened this issue May 22, 2017 · 3 comments

Comments

@toddnestor
Copy link
Contributor

With changing this gem to have separate instances, it'd be good to be able to add some default configuration options (default shortcodes, templates, etc).

I had originally called this a "global configuration" but I think @kernow's suggestion of calling it the "default configuration" probably makes more sense.

I can handle building this, let's just agree on the terminology first.

@kernow
Copy link
Owner

kernow commented May 23, 2017

My preference is for "default" as it implies a default will be used unless it is overwritten. I'm happy for you to go ahead unless anyone comes in with another opinion.

@toddnestor
Copy link
Contributor Author

I think I'll go ahead and do this PR tonight/tomorrow morning.

When are you thinking of doing the 2.0 release of the gem?

@kernow
Copy link
Owner

kernow commented Jun 1, 2017

@toddnestor I'm going to add some deprecation warnings around the singleton usage and do another 1.x release and leave that for a while so that people can update their code. Then I will do a 2.0 release which removes singleton usage.

Any new features can be released in a 1.x release, only breaking changes require a major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants