New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play catch up w/ upstream #39

Closed
arlolra opened this Issue Jun 6, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@arlolra
Collaborator

arlolra commented Jun 6, 2016

We shouldn't fall too far behind.

@arlolra arlolra added the enhancement label Jun 15, 2016

arlolra added a commit that referenced this issue Jun 22, 2016

Bump third_party/webrtc to f3369829
 * branch-heads/52

 * Part of #39

arlolra added a commit that referenced this issue Jun 22, 2016

Bump third_party/webrtc to f3369829
 * branch-heads/52

 * Part of #39

@arlolra arlolra closed this in #42 Jun 22, 2016

arlolra pushed a commit to arlolra/tor-browser-bundle that referenced this issue Aug 13, 2016

David Fifield
Update WEBRTC_TAG to branch-heads/52.
Set to f336982 as in keroserene/go-webrtc#39.

Actually, at this moment, branch-heads/52 is 3 commits ahead (ca7fe7e)
of where it was at the time of GitHub #39.

I had to change "gyp_webrtc" to "gyp_webrtc.py" as the former is no
longer executable:
	+ webrtc/build/gyp_webrtc
	bash: line 288: webrtc/build/gyp_webrtc: Permission denied
"gyp_webrtc" just does:
	execfile(__file__ + '.py')

I added "werror=" to GYP_DEFINES because of this warning that stopped
the build by being treated as an error:
	../../webrtc/voice_engine/channel.cc: In member function 'void webrtc::voe::Channel::Demultiplex(const int16_t*, int, size_t, size_t)':
	../../webrtc/voice_engine/channel.cc:2954:13: error: '*((void*)& codec +44)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
	   CodecInst codec;
		     ^
	../../webrtc/voice_engine/channel.cc:2954:13: error: '*((void*)& codec +36)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
	cc1plus: all warnings being treated as errors
I suspect that more recent versions of GCC than our current 5.1.0 don't
raise a warning here.

I changed the test target name from
libjingle_peerconnection_unittest.isolated to
peerconnection_unittests.isolated. It seems that libjingle is going to
stop existing as a separate concern. Anyway, the old target name doesn't
exist:
	+ ninja -C out/Release libjingle_peerconnection_unittest.isolated
	ninja: Entering directory `out/Release'
	ninja: error: unknown target 'libjingle_peerconnection_unittest.isolated'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment