Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control frames fix #41

Merged
merged 2 commits into from Jan 4, 2016

Conversation

@darkl
Copy link
Contributor

darkl commented Jan 1, 2016

This is an attempt to solve this issue.

Due to The WebSocket Protocol RFC

o Control frames (see Section 5.5) MAY be injected in the middle of
a fragmented message. Control frames themselves MUST NOT be
fragmented.

However, it seems that WebSocket4Net currently lacks this: when receiving a frame it checks if the frame has the FIN flag and if it does it ends the fragmented message. However, control frames might be injected in the middle of a fragmented message. Those shouldn't be considered as part of the whole fragmented message and should be treated separately.

My apologies for non informative commit messages and for two commits. I tried to edit these files on my computer, but if I do so it looks as I removed and added the entire whole files, so instead I edited online.

Elad

kerryjiang added a commit that referenced this pull request Jan 4, 2016
Control frames fix
@kerryjiang kerryjiang merged commit 59200cd into kerryjiang:master Jan 4, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.