Added test timeout and self-terminating tests #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesla
added a commit
that referenced
this pull request
Jun 20, 2013
Added test timeout and self-terminating tests
|
Nice, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included in this pull request:
In an attempt to get substack/testling to run, I am inspecting the modules it depends on.
As it turns out, I did not have
xvfbinstalled on my machine which caused me to miss the assertions ever get made. After installingxvfb, I verified the assertions were running but the process still wasn't terminating. As a result, I added some self-terminating logic. As a gesture of good faith, I added in a test timeout for future brave lost souls.