Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-character ValueSeparators #12

Merged
merged 4 commits into from Jun 7, 2020

Conversation

kevin-montrose
Copy link
Owner

@kevin-montrose kevin-montrose commented Jun 4, 2020

Implements multi-character value separators.

Visible changes:

  • Options.ValueSeparator is now a string
    • It cannot be null or empty
    • It's first character cannot match any of the other special characters
    • If whitespace is being trimmed, it cannot contain whitespace

Internal notable changes:

  • It's now possible for a the reader state machine to need to look ahead, which can increase the frequency of characters being left in the pending buffer
  • Minimum memory needing for a read buffer is now 2 * (length of ValueSeparator) instead of 2

…character value separators per #10 (comment); still leaves read changes to be made; test coverage will need to be expanded to cover new cases as well
@kevin-montrose kevin-montrose merged commit e64f7cf into vNext Jun 7, 2020
@kevin-montrose kevin-montrose deleted the issue-10/multi-character-value-separators branch Jun 7, 2020
@kevin-montrose kevin-montrose mentioned this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant