Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Span & Memory overloads for writing comments #16

Merged
merged 3 commits into from Jun 7, 2020
Merged

Adds Span & Memory overloads for writing comments #16

merged 3 commits into from Jun 7, 2020

Conversation

kevin-montrose
Copy link
Owner

Visible changes:

  • adds IWriter<TRow>.WriteComment(ReadOnlySpan<char>)
  • adds IAsyncWriter.WriteCommentAsync(ReadOnlyMemory, CancellationToken)`

Internal changes:

  • write comment paths no longer use strings
  • Utils.Split has been removed
  • a ReadOnlySequence<char> will no longer be allocated for multi-line comments

@kevin-montrose
squashes 7 commits; adds Span & Memory overloads for writing comments…
ea88914 
…, and removes allocations that would happen if a comment needed to be broken into multiple lines
@kevin-montrose kevin-montrose mentioned this pull request Jun 7, 2020
Open
@kevin-montrose kevin-montrose merged commit c6819df into vNext Jun 7, 2020
@kevin-montrose kevin-montrose deleted the issue-11/span-memory-comment-writing branch June 7, 2020 22:21
@kevin-montrose kevin-montrose mentioned this pull request Aug 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kevin-montrose