Fix pyflakes and pep8 errors #229
Conversation
|
fwiw, the |
|
Looks like I caused some conflicts when merging #228. Can you rebase? Also, I noticed quite a few new asserts. Is this purely for pep8 reasons? Does flake8 require an assert per test or something? |
|
pyflakes requires that all variables are used. |
|
Ohh gotcha. I think I would prefer to do the first option (remove ..as cass) since I prefer to have fewer asserts per test. Asserts without much meaning to the test can dillute the meaning of the important assert. I strive for a single assert per test but often don't achieve it :) |
| @@ -9,16 +8,21 @@ def test_once_record_mode(tmpdir): | |||
| with vcr.use_cassette(testfile, record_mode="once"): | |||
| # cassette file doesn't exist, so create. | |||
| response = urlopen('http://httpbin.org/').read() | |||
There was a problem hiding this comment.
should I also change lines like this to urlopen('http://httpbin.org/').read() , and remove the assert response ?
(It is very late here, so I'll pick this up tomorrow and revise it to better suit your tastes.)
There was a problem hiding this comment.
Yeah, if we're not doing anything with the variable I suppose we don't need to create it. (BTW thanks a lot for doing this! Having all the code be pep8 gives a nice clean feeling :) 👍
Use extra asserts to use previously unused variables in tests, such as `cass` and `response`. Fix only pyflakes errors in docs/conf.py
|
Thanks for the cleanup! |
Use extra asserts to use previously unused variables in tests,
such as
cassandresponse.Fix only pyflakes errors in docs/conf.py