Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aiohttp support #266

Merged
merged 14 commits into from Aug 14, 2016

Conversation

Projects
None yet
3 participants
@lamenezes
Copy link
Collaborator

commented Aug 4, 2016

Solves #209

@lamenezes lamenezes force-pushed the lamenezes:aiohttp-support branch Aug 4, 2016

@lamenezes lamenezes force-pushed the lamenezes:aiohttp-support branch to 1167b9e Aug 4, 2016

@kevin1024

This comment has been minimized.

Copy link
Owner

commented Aug 4, 2016

😯wow!

@kevin1024

This comment has been minimized.

Copy link
Owner

commented Aug 9, 2016

Thanks for the contribution. See if you can goof with the travis/pytest config so it only runs the aiohttp tests on python3.4+

@lamenezes lamenezes force-pushed the lamenezes:aiohttp-support branch to 574b22a Aug 10, 2016

lamenezes added some commits Aug 10, 2016

@lamenezes lamenezes force-pushed the lamenezes:aiohttp-support branch Aug 10, 2016

@lamenezes lamenezes force-pushed the lamenezes:aiohttp-support branch 3 times, most recently to 9a52148 Aug 11, 2016

lamenezes added some commits Aug 11, 2016

@lamenezes lamenezes force-pushed the lamenezes:aiohttp-support branch 2 times, most recently to c65ff0e Aug 11, 2016

@lamenezes

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 12, 2016

The newest version of flake8 (>3) [1] does not support python 2.6, 3.2 and 3.3 and it is causing this build to fail when running tests for py26-flakes

[1] https://flake8.pycqa.org/en/latest/release-notes/3.0.0.html

@kevin1024

This comment has been minimized.

Copy link
Owner

commented Aug 12, 2016

Heh ok. See if you can disable flakes on py26 I'm that case

@lamenezes

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 12, 2016

It finally passed 😄

@kevin1024 kevin1024 merged commit f9d7ccd into kevin1024:master Aug 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@drgarcia1986

This comment has been minimized.

Copy link

commented Aug 15, 2016

👏 👏 👏
Thanks a lot @lamenezes

@lamenezes lamenezes deleted the lamenezes:aiohttp-support branch Sep 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.