Make the build reproducible #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lamby thanks for your PR! can you update your branch so we can follow the review/merge? |
Whilst working on the Reproducible Builds effort [0], we noticed that vcrpy could not be built reproducibly. This is due to the documentation including the absolute build path via Python default arguments. This was originally filed in Debian as #895269 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/895269 Signed-off-by: Chris Lamb <lamby@debian.org>
lamby
force-pushed
the
895269-vcrpy-please-make-the-build-reproducible
branch
from
d4974b6
to
f317490
Compare
|
@lamenezes Done. (The test failures appear to be unrelated to this change AFAICT) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort [0], we noticed
that vcrpy could not be built reproducibly.
This is due to the documentation including the absolute build path
via Python default arguments.
This was originally filed in Debian as #895269 [1].
[0] https://reproducible-builds.org/
[1] https://bugs.debian.org/895269
Signed-off-by: Chris Lamb lamby@debian.org