Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort input file list #20

Merged
merged 1 commit into from Mar 22, 2022
Merged

Sort input file list #20

merged 1 commit into from Mar 22, 2022

Conversation

bmwiedemann
Copy link
Contributor

Sort input file list
so that epub2txt builds in a reproducible way
in spite of indeterministic filesystem readdir order

See https://reproducible-builds.org/ for why this is good.

This PR was done while working on reproducible builds for openSUSE.

so that `epub2txt` builds in a reproducible way
in spite of indeterministic filesystem readdir order

See https://reproducible-builds.org/ for why this is good.
@kevinboone kevinboone merged commit 973ffba into kevinboone:master Mar 22, 2022
@kevinboone
Copy link
Owner

I'm not sure that anything in the source is going to be affected by the compilation or link order; still, it seems a reasonable change. Thanks.

@bmwiedemann bmwiedemann deleted the sort branch March 23, 2022 05:48
@bmwiedemann
Copy link
Contributor Author

For the record: The link order of $(OBJECTS) does influence the resulting binary, at least with gcc+binutils.

@kevinboone
Copy link
Owner

Sure; but does it affect whether something works, or does not work?

@bmwiedemann
Copy link
Contributor Author

It might work the same way, but a) there is no guarantee or proof and b) reproducible builds aims at bit-identical results, so you can tell people this one hash value is the expected good one (when building with a given build env).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants