Extend length of project orderNumber string

[iusgit]

Is your feature request related to a problem? Please describe.
The project orderNumber string is limited to 20 characters. Sometimes costumers have complicated ways to create their numbers and we have hit the limit several times.

Describe the solution you'd like
Can we extend the limit to some generic value e.g. 256?
I think I could try to do that with some guidance.

As far as I understand it would mean to:

• adapt 2 lines here: https://github.com/kevinpapst/kimai2/blob/b7cf9cd776593cb8b05c7d70109d04d4aaa4f86c/src/Entity/Project.php#L115
• define migration to enlarge fields in database

Describe alternatives you've considered
We have also purchased the MetaFieldsBundle and could create a custom field. However, I think our proposal could save some trouble in the future.

[kevinpapst]

Yeah, in 20 character you can fit billions of combinations and 255 character is way too much.
What is the longest number you saw in reality?

[iusgit]

So, order "numbers", which made problems, had strings with a structure like 1234567890/WXYZ/SUBPROJECT/EMPLOYEE.
To allow this, one would need at least 50 characters.

Is it necessary to be strict with that field?

[kevinpapst]

I am not saying no, but blindly increasing every field to 255 chars is just not the right way to go.
For large queries increased field sizes might put more load on the entire system. There is a reason why you can limit the field size in databases, right?

If you can live with 50 characters, I am fine with increasing the field accordingly.

Besides the linked code pieces, please adjust this test as well:
https://github.com/kevinpapst/kimai2/blob/master/tests/API/ProjectControllerTest.php#L291
Simply add a 50 character long string and compare it afterwards.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.