Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some importer bugs/improvements #553

Closed
labor4 opened this issue Feb 10, 2019 · 5 comments · Fixed by #569

Comments

@labor4
Copy link

@labor4 labor4 commented Feb 10, 2019

V0.7 stable, Importer from v1:

  • If a userID of timesheet entry points to a user that is not in the (v1) system anymore, the import fails.
  • country "ch" is not accepted. must be "CH".
  • can we set the currency somehow? I had "Fr." but it had been forcefully adopted into EUR. We still don't want that. ;-)
  • please advise that install dir be $HOME, because I think ROOT-DIR is sometimes meant as DOCUMENT_ROOT
  • also, "public" dir is mandatory, I think for some time (or even up to now) Plesk systems used "httpdocs" as default

is it correct that expenses are not implemented yet? do you plan those?

Gute Grüsse!
manu

@kevinpapst

This comment has been minimized.

Copy link
Owner

@kevinpapst kevinpapst commented Feb 10, 2019

Thanks for the feedback 👍 Some important improvements were mentioned.

The currency is defined through the customers. So you need to edit each customer and set their currency to CHF. I'll see if another importer flag can be added to do that automatically.

Do you want to say, that the docu should be improved with your two ch vs CH and $HOME vs ROOT_DIR comments?

I don't understand your Plesk comment. I don't think that Plesk needs a directory called httpdocs, but if so: create a symlink to public. But IMO you can configure the document root for every subdomain to a directory of your choice.

TODO

  • Create missing users on the fly (like its already done with customers)
  • Add flag for customer currency
  • Update importer docu that country needs to be a uppercase-two character code
  • Check installation docu about $HOME vs ROOT-DIR vs DOCUMENT_ROOT
@labor4

This comment has been minimized.

Copy link
Author

@labor4 labor4 commented Feb 10, 2019

hi Kevin
HOME: yes docs, just mention it
Countrycode: strtoupper?
Plesk: I meant defaults, but one can change that yes. I was not used to store stuff sub-docroot so it took a bit of adapting

edit: now i come to think of it: the "public" naming will probably mislead others too as it feels somewhat normal to just base everything into the docroot you have. but dont know. maybe its just me. composer command crashes without explanation if wrong name.

cheers m

@kevinpapst

This comment has been minimized.

Copy link
Owner

@kevinpapst kevinpapst commented Feb 13, 2019

Not sure if you already handled the import by adjusting the data in your database.
If not, there is a branch in PR #569 which fixes your requests (create unknown user during import).

@kevinpapst

This comment has been minimized.

Copy link
Owner

@kevinpapst kevinpapst commented Feb 13, 2019

Now available in master

@lock

This comment has been minimized.

Copy link

@lock lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.