Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to edit single system config section in modal #1490

Merged
merged 1 commit into from Feb 22, 2020

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Feb 22, 2020

Description

A clear and concise description of what this pull request adds or changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.8 milestone Feb 22, 2020
@codecov
Copy link

codecov bot commented Feb 22, 2020

Codecov Report

Merging #1490 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1490      +/-   ##
============================================
+ Coverage     92.65%   92.66%   +<.01%     
- Complexity     4317     4320       +3     
============================================
  Files           416      416              
  Lines         13382    13393      +11     
============================================
+ Hits          12399    12410      +11     
  Misses          983      983
Impacted Files Coverage Δ Complexity Δ
src/Controller/SystemConfigurationController.php 98.71% <100%> (+0.06%) 21 <5> (+3) ⬆️

@kevinpapst kevinpapst merged commit 6c7477f into master Feb 22, 2020
@kevinpapst kevinpapst deleted the config-section branch February 22, 2020 17:53
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant