Preparations for coming features #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1818 +/- ##
============================================
+ Coverage 92.26% 92.36% +0.09%
- Complexity 5043 5064 +21
============================================
Files 472 471 -1
Lines 15636 15670 +34
============================================
+ Hits 14427 14474 +47
+ Misses 1209 1196 -13
|
pinedev
pushed a commit
to pinedevstudio/kimai2
that referenced
this pull request
Mar 23, 2021
* removed unused convert_tz code * added timestampable listener to support automatic updates of change columns * added modified_at, billable and category timesheet fields * new timesheet API query parameter modified_after
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
convert_tzcodemodified_atfield for timesheets to allow queries for records changed after a certain date (used asmodified_afterin timesheet GET collection API)This PR adds new ground work for features that will be added in the future:
billablefield to mark timesheets as billable, so we can distinguish between paid work and internal taskscategoryfield to timesheets to distinguish between multiple types of records (like work, holidays, sickness...). This is NOT yet used and all records map to the "work" category.Types of changes
Checklist
composer code-check)