Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Localized date-inputs and daterange-picker #540
Improvements in this PR
Localized date input fields
Added daterange picker for toolbars
Wow! really nice! I wanted to create a feature request for this, but you were quicker! It's very user friendly, thank you! I don't see any bugs.
Minor problem: I see that the start of the week depends on the selected language. If I change to english it's from sunday to saturday, in hungarian it's from monday to sunday. Is it possible to change this independently from the language? It can create confusion in a multi language environment, where the users use different languages. Maybe an option in the settings "start of week" or in a .env or similar file where I can select from "use locale" and "force monday/sunday". If it's not fixed it's ok, it's not a common feature, e.g. it's not implemented in nextcloud neither. If it's implemented it should affect the calendar view as well.
Thanks for the test and format feedback @infeeeee
Yes, there is a setting for the first day of the week in the JS date-picker. I am not sure about the calendar, but every calendar component should support this.
Having this setting in a config sounds as wrong as binding it to the users language. Kimai supports full locales as well, but unless we don't really need them, I'd like to avoid the configuration overhead.