Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily stats in timesheet #552

Merged
merged 9 commits into from Feb 13, 2019
Merged

Daily stats in timesheet #552

merged 9 commits into from Feb 13, 2019

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Feb 9, 2019

This PR adds a new user preference "Show daily stats in timesheet", which is deactivated b default.
If activated, the timesheet view will contain a visually highlighted statistic row between days

If a day has activities for multiple customers with different currencies, each currency will be summed up on ints own and displayed on a new line:
bildschirmfoto 2019-02-12 um 14 02 13

Fixes #495
Maybe fixes #526

@infeeeee
Copy link
Contributor

  • No summary for the day on the bottom of the page. If only one page needed to show the times, no summary for the first day of the timespan. If pagination needed and pagination cuts a day in half, no summary for the times on the first page, and the summary on the second page shows only the times on that page.
  • Different currencies summarized to one value, it doesn't make sense. No exchange rates in kimai, and I think it's not a necessary feature, so maybe different currencies should be added separately, and show up as something like this: PHP594.18 + AZN1,139.60, or each on a new line

@kevinpapst
Copy link
Member Author

Thanks for the detailed report:

  • Added stats for the last entry in each table
    • I can live with "no report for the day that is cut in half" - too complicated to work around that one. But due to the point above you get a report for the entries which can be seen.
  • Different currencies: I can try to count each currency individually, but then is the question: how often does that happen in reality? When using the demo with the Data-Fixtures yes, but in real live?

@infeeeee
Copy link
Contributor

Currencies: Yes, it's not a very common use case, and if I filter by customer they can't show up, but I think even showing nothing would be better then adding them as one currency.

@kevinpapst
Copy link
Member Author

True, good argument. I will update the PR later on.

@infeeeee
Copy link
Contributor

It's much better now, and on a new line they look good, thank you!

# Conflicts:
#	public/build/app.css
#	public/build/manifest.json
@kevinpapst kevinpapst merged commit 2c6f57c into master Feb 13, 2019
@kevinpapst kevinpapst deleted the daily-stats branch February 13, 2019 14:37
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants