Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix english translation for 'info' #995

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@trentks
Copy link
Contributor

trentks commented Jul 30, 2019

Description

In english, 'information' and its shortened form 'info' are their own plurals. Simple spelling change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license
In english, 'information' and its shortened form 'info' are their own plurals.
Copy link
Owner

kevinpapst left a comment

ignore the failing build, something changed on travis that caused this. I will merge the PR nevertheless later, once the build is working again.

@kevinpapst kevinpapst added this to the 1.2 milestone Aug 1, 2019
@kevinpapst kevinpapst merged commit b0e03bb into kevinpapst:master Aug 1, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@kevinpapst

This comment has been minimized.

Copy link
Owner

kevinpapst commented Aug 1, 2019

Thanks @trentks 👍

@kevinpapst

This comment has been minimized.

Copy link
Owner

kevinpapst commented Aug 1, 2019

Pleas let me know if you find other weird translations, I am doing my best, but its not my mothers tongue...

@trentks trentks deleted the trentks:patch-1 branch Aug 1, 2019
@trentks

This comment has been minimized.

Copy link
Contributor Author

trentks commented Aug 1, 2019

Hi @kevinpapst,

Just read through the whole translations file... and submitted #1002. There is one error that I found in the web-files that I can't see how it arises in the translation file. See the screenshot below:
2019-08-02-113414_1919x1079_scrot

On the "Administration->Tags" page... it says at the top "Tags allow, to freely combine timesheet records into a resultset". Just replacing the comma with " you" would be enough... but otherwise a better sentence might be "Tags allow for the free combination of timesheet records into a result set".

Cheers, Trent.

@kevinpapst

This comment has been minimized.

Copy link
Owner

kevinpapst commented Aug 2, 2019

Hi @trentks ,
actually there is not only messages.en.xliff, but every file in the translation directory that ends with .en.xliff could need a checkup. The tags sentence for example can be found here:
https://github.com/kevinpapst/kimai2/blob/master/translations/tags.en.xliff

@lock

This comment has been minimized.

Copy link

lock bot commented Oct 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.