New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates SapiEmitter to use zend-httphandlerrunner #2

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@bradykeeling
Copy link

bradykeeling commented Oct 15, 2018

Hey Kevin!

This updates the Zend emitter package since "Zend\Diactoros\Response\SapiEmitter" is now deprecated. https://docs.zendframework.com/zend-diactoros/v1/emitting-responses/

You may want to update the Composer package reference in your article as well, as it might lead to some confusion if someone is trying to work alongside it.

Great stuff man! Super helpful.

@kevinsmith

This comment has been minimized.

Copy link
Owner

kevinsmith commented Oct 16, 2018

Sweet! Thanks for catching this. I'll take a look at it later today or tomorrow.

@kevinsmith

This comment has been minimized.

Copy link
Owner

kevinsmith commented Oct 18, 2018

Solid change, thanks! I think this is gonna have to be part of a larger code and blog post update, so I'm gonna wait a bit to pull it in.

I'm currently using Relay as the PSR-15 implementation, but it's still not out of alpha. If I'm gonna use zend-httphandlerrunner for the emitters, might as well use it for the PSR-15 implementation too. (Not entirely sure why the ZF team felt like a PSR-7 and PSR-15 implementation should be bundled together in the same package, but whatever.)

@kevinsmith kevinsmith changed the base branch from master to update-middleware-runner Nov 13, 2018

@kevinsmith kevinsmith merged commit 10635a8 into kevinsmith:update-middleware-runner Nov 13, 2018

@kevinsmith

This comment has been minimized.

Copy link
Owner

kevinsmith commented Jan 12, 2019

Finally updated it to use Narrowspark's emitter instead. That allows the blog post to continue showing a diverse selection of interoperable packages built by unrelated maintainers. Thanks for giving me the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment