Removing button and image. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine to me. I don't know why I'd need these button-like types as a field type in Siren. I'll let this hang out for a minute, though, unless someone would like to offer a use case. |
|
👍 |
|
No objection here. |
kevinswiber
added a commit
that referenced
this pull request
Jul 10, 2015
Removing button and image.
|
Thanks, @mdobson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
buttonand theimageinput types for action fields.In the context of sending an HTTP request it seems weird to have these as available input types. They can't really be set as parameters in a request body.
See here for reference: http://www.w3.org/TR/html5/single-page.html#the-input-element