From a6a3a60b99f665ca2d0cdac911c98d7f0a9e2a5d Mon Sep 17 00:00:00 2001 From: Christian Ehrhardt Date: Thu, 29 Aug 2019 17:30:03 +0200 Subject: [PATCH] build: avoid overlinking [ upstream commit 31b798a6f08e9b333b94b8bb26910209aa810b73 ] A while ago telemetry was added in 57ae0ec6 and it also added as-needed to config/meson.build. This seems no more needed these days as due to other build changes the ordering in buildlogs is: [...] -lrte_telemetry [...] -Wl,--no-as-needed [...] Which means telemetry no more benefits from --no-as-needed anyway. Overlinking problems get triggered by the meson generated pkgconfig which will have: [...] -Wl,--no-as-needed This will overlink and in addition anything that follows as it also doesn't wrap back to --as-needed. So if a projects includes dpdk libs + it will also consider with --no-as-needed. Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759 Fixes: 57ae0ec62620 ("build: add dependency on telemetry to apps with meson") Signed-off-by: Christian Ehrhardt Acked-by: Luca Boccassi --- config/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/config/meson.build b/config/meson.build index d4d450829a..e92be6c479 100644 --- a/config/meson.build +++ b/config/meson.build @@ -53,7 +53,6 @@ dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1) dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8) add_project_link_arguments('-Wl,--no-as-needed', language: 'c') -dpdk_extra_ldflags += '-Wl,--no-as-needed' # use pthreads add_project_link_arguments('-pthread', language: 'c')