From e2b0823a95ba389906b46b90979fc0f2d142b87c Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 10 Feb 2022 15:09:05 -0800 Subject: [PATCH] test/bpf: skip dump if conversion fails [ upstream commit 78e7b29ff10c234b44f20fe7d031d60748920c2d ] If conversion of cBPF to eBPF fails (in rte_bpf_convert) then the test should not try and print the result. Coverity issue: 373661 Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF") Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- app/test/test_bpf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 2d755a872f..c422fedf1f 100644 --- a/app/test/test_bpf.c +++ b/app/test/test_bpf.c @@ -3259,8 +3259,10 @@ test_bpf_dump(struct bpf_program *cbf, const struct rte_bpf_prm *prm) printf("cBPF program (%u insns)\n", cbf->bf_len); bpf_dump(cbf, 1); - printf("\neBPF program (%u insns)\n", prm->nb_ins); - rte_bpf_dump(stdout, prm->ins, prm->nb_ins); + if (prm != NULL) { + printf("\neBPF program (%u insns)\n", prm->nb_ins); + rte_bpf_dump(stdout, prm->ins, prm->nb_ins); + } } static int