diff --git a/java/src/com/android/inputmethod/keyboard/KeyboardView.java b/java/src/com/android/inputmethod/keyboard/KeyboardView.java index 6af4123c..e69dc581 100644 --- a/java/src/com/android/inputmethod/keyboard/KeyboardView.java +++ b/java/src/com/android/inputmethod/keyboard/KeyboardView.java @@ -974,5 +974,9 @@ protected void onDetachedFromWindow() { if (mPreviewPlacer != null) { mPreviewPlacer.removeAllViews(); } + if (mBuffer != null) { + mBuffer.recycle(); + mBuffer = null; + } } } diff --git a/java/src/com/android/inputmethod/keyboard/LatinKeyboard.java b/java/src/com/android/inputmethod/keyboard/LatinKeyboard.java index 34527204..c51f1849 100644 --- a/java/src/com/android/inputmethod/keyboard/LatinKeyboard.java +++ b/java/src/com/android/inputmethod/keyboard/LatinKeyboard.java @@ -59,8 +59,8 @@ public class LatinKeyboard extends Keyboard { private final int mSpacebarTextColor; private final int mSpacebarTextShadowColor; private float mSpacebarTextFadeFactor = 0.0f; - private final HashMap> mSpaceDrawableCache = - new HashMap>(); + private final HashMap mSpaceDrawableCache = + new HashMap(); private final boolean mIsSpacebarTriggeringPopupByLongPress; /* Shortcut key and its icons if available */ @@ -249,13 +249,13 @@ private static String layoutSpacebar(Paint paint, Locale locale, int width, private BitmapDrawable getSpaceDrawable(Locale locale, boolean isAutoCorrection) { final Integer hashCode = Arrays.hashCode( new Object[] { locale, isAutoCorrection, mSpacebarTextFadeFactor }); - final SoftReference ref = mSpaceDrawableCache.get(hashCode); - BitmapDrawable drawable = (ref == null) ? null : ref.get(); - if (drawable == null) { - drawable = new BitmapDrawable(mRes, drawSpacebar( - locale, isAutoCorrection, mSpacebarTextFadeFactor)); - mSpaceDrawableCache.put(hashCode, new SoftReference(drawable)); + final BitmapDrawable cached = mSpaceDrawableCache.get(hashCode); + if (cached != null) { + return cached; } + final BitmapDrawable drawable = new BitmapDrawable(mRes, drawSpacebar( + locale, isAutoCorrection, mSpacebarTextFadeFactor)); + mSpaceDrawableCache.put(hashCode, drawable); return drawable; }