Permalink
Switch branches/tags
Nothing to show
Commits on Jul 12, 2013
  1. Patch ingestion.

    nanaze committed Jul 12, 2013
    New issue 572 by Nicholas.J.Santos: Add a nodejs script loader
    http://code.google.com/p/closure-library/issues/detail?id=572
    
    Fixes issue 572.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49279956
  2. Factor out the sanity check in goog.structs.StringSet to goog.asserts…

    nanaze committed Jul 12, 2013
    ….assertObjectPrototypeIsIntact.
    
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49273599
  3. Add support for "Tomorrow" to goog.date.relative.formatDay and fall b…

    nanaze committed Jul 12, 2013
    …ack to an absolute date for future dates after tomorrow.
    
    Right now, it formats all future dates as "Today".
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49247837
  4. Automated g4 rollback of changelist 49236167.

    nanaze committed Jul 12, 2013
    *** Reason for rollback ***
    
    Breaks other projects when compiled. Static methods, like goog.graphics.AffineTransform.getScaleInstance, are failing with has no method errors.
    
    *** Original change description ***
    
    Move AffineTransform from goog.graphics to goog.math, with an alias
    for existing users.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49246768
  5. Move AffineTransform from goog.graphics to goog.math, with an alias

    nanaze committed Jul 12, 2013
    for existing users.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49236167
  6. Clean up deprecation warnings for goog.userAgent.isVersion

    nanaze committed Jul 12, 2013
    CL automatically created by:
    replace_string \
    --excludefile="googledata" \
    goog\\.userAgent\\.isVersion\\b \
    goog.userAgent.isVersionOrHigher
    
    Tested:
    TAP presubmits for global presubmit queue
    http://test/OCL:49187989:BASE:49212032:1373534335113:8b2d403b
    Some tests failed; test failures are believed to be unrelated to this CL
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49235644
  7. Undeprecate the generic bits of the goog.graphics until a new locatio…

    nanaze committed Jul 12, 2013
    …n is decided on.
    
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49228334
  8. Updated samplecomponent.js to use goog.base and goog.ui.Component.get…

    nanaze committed Jul 12, 2013
    …Handler.
    
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49188520
  9. Add webview tag events to goog.events.EventType

    nanaze committed Jul 12, 2013
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49173692
  10. Fix return value in overridden dispatchEvent of MockActivityMonitor.

    nanaze committed Jul 12, 2013
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49145116
  11. Bugfixes for cl/49064739.

    nanaze committed Jul 12, 2013
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49125166
  12. Make sure error.message is not undefined.

    nanaze committed Jul 12, 2013
    If error.message is undefined, then the truncation introduced to
    ErrorReporter in CL 47061426 causes an exception.
    
    The message can be undefined when error is not an Error object. This can
    happen with any object, since anything can be thrown, but one common case
    is when error is a GWT exception.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49119020
  13. Update User-Agent parsing to deal with IE11.

    nanaze committed Jul 12, 2013
    IE11's User-Agent string is significantly different from previous
    versions; it drops the MSIE token entirely and adds a "like Gecko"
    token.
    
    Example: Mozilla/5.0 (Windows NT 6.3; Trident/7.0; rv 11.0) like Gecko
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49115927
  14. Bugfixes for cl/49064739.

    nanaze committed Jul 12, 2013
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49110979
Commits on Jul 9, 2013
  1. Fix jsdoc for verifyInvocation in closure labs mock. It doesn't look …

    nanaze committed Jul 9, 2013
    …like this method is intended to return anything.
    
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49071189
  2. Recognize RLM as an RTL character and LRM as an LTR character in

    nanaze committed Jul 9, 2013
    goog.i18n.bidi methods, e.g. estimateDirection(). This makes sure that
    fake-bidi strings (Latin-script text where each word is wrapped in
    RLM RLO ... PDF RLM so that the text as a whole behaves as if it were
    written in an RTL script) are recognized as RTL.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49056400
  3. Refactoring of the init() function and added addItemToDragList(list, …

    nanaze committed Jul 9, 2013
    …item, opt_index) to allow adding new items to the lists.
    
    This change is needed for DragListGroupWithPool (subclass of DragListGroup) drag and drop control used in Session Seeker 2 control panel, that allows to copy items by dragging them from one special list called 'pool'. To achieve this, it is needed to add new items after the control was initialized.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49045966
  4. Don't start polling when one chunk fails on Opera browser, otherwise …

    nanaze committed Jul 9, 2013
    …polling timer causes JS error because this.xmlHttp_ = null.
    
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=49032407
  5. Make sure saved ranges preserve reversedness.

    nanaze committed Jul 9, 2013
    This is a patch from Nick Santos.
    
    Fixes issue 569
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48907543
  6. Ensure Array-like types have a properly typed 'length' property in

    nanaze committed Jul 9, 2013
    preparation for cl/48890778.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48893987
  7. Allow stack-free disposable monitoring (but not used by default).

    nanaze committed Jul 9, 2013
    The intent is to use this for tests which assert that there are no undiposed objects,
    without the overhead of tracking where each are created.
    
    Just the enum change, I'll switch to this in timely afterwards, and contact a
    few other teams using the DisposableMonitoring pattern in their own tests.
    
    Testing:
    Unit test added
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48886987
  8. Automated g4 rollback of changelist 48871006.

    nanaze committed Jul 9, 2013
    *** Reason for rollback ***
    
    Breaks dragging when full page zoom is used. The dragged element doesn't closely follow the mouse.
    Reason: uses the deprecated screenX and screenY attributes, and assumes that 1 screen pixel always equals to 1 client pixel.
    
    *** Original change description ***
    
    1. Support target and handle in different document scope. e.g. target is iframe element, handle is an element inside that iframe. Attach listeners on additional document (if necessary) and doing arithmetic relative to the screen coordinate so that one can drag if things cross documents.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48886310
  9. 1. Support target and handle in different document scope. e.g. target…

    nanaze committed Jul 9, 2013
    … is iframe element, handle is an element inside that iframe. Attach listeners on additional document (if necessary) and doing arithmetic relative to the screen coordinate so that one can drag if things cross documents.
    
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48871006
  10. Automated g4 rollback of changelist 48857947.

    nanaze committed Jul 9, 2013
    *** Reason for rollback ***
    
    Disallowing nulls in the type signature broke builds.
    
    *** Original change description ***
    
    Disallow null and undefined as parameters to goog.net.Jsonp.
    
    Passing null or undefined is almsot certainly a programming error,
    and it causes different practical effects in Chrome (where it does nothing)
    and Firefox (where it tries to load the current page as jsonp).
    
    CL 47652415 is an example of real-world breakage that would have been
    caught by this assertion.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48862814
  11. Disallow null and undefined as parameters to goog.net.Jsonp.

    nanaze committed Jul 9, 2013
    Passing null or undefined is almsot certainly a programming error,
    and it causes different practical effects in Chrome (where it does nothing)
    and Firefox (where it tries to load the current page as jsonp).
    
    CL 47652415 is an example of real-world breakage that would have been
    caught by this assertion.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48857947
  12. Automated g4 rollback of changelist 48705720.

    nanaze committed Jul 9, 2013
    *** Reason for rollback ***
    
    For in IE8-, event may be stopped in capture simulation phase. In this cl/48705720, system can't stop propagation when the event was stopped in capture simulation phase.
    
    *** Original change description ***
    
    Simplify IE capture simulation:
    * When capture simulation occurs, we now let the browser
    handles the bubble phase.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48820351
  13. Fix tests that will be broken when we enable distributed listener map

    nanaze committed Jul 9, 2013
    in goog.events. Distributed listener map removes a major source of leaks
    in goog.events. However, with this change, a few APIs are impossible to
    implement:
    
    goog.events.removeAllNativeListeners()
    goog.events.removeAll() with no argument
    These should be replaced with explicit goog.events.removeAll(src)
    when src is singleton shared between tests (e.g. window, document,
    or shared elements). Otherwise, it's safe to remove this.
    
    goog.events.getTotalListenerCount()
    This now returns an estimate (and will soon return 0). Tests that
    rely on this accurately returning listener count will start failing.
    This usage is typically removed from the tests.
    
    Direct access to internal data structure (such as goog.events.listeners_)
    are also removed, since many of these internal data structures will be gone.
    
    Since this means that the tests may no longer be testing the right thing
    (e.g. no longer testing that listeners on window/document are properly
    removed), please review the change and determine if the loss of such
    tests are detrimental to your code. If you have a better fix, please
    do submit your fix and let me know so that I can discard my change.
    To test your fix, you can patch cr/48429537.
    
    Tested:
    TAP presubmits for global presubmit queue
    http://test/OCL:48722980:BASE:48723008:1372499357778:315f8a10
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48780470
  14. Remove baseUrl_ attribute from goog.History.

    nanaze committed Jul 9, 2013
    The original request path may change from the time that goog.History is
    instantiated (via HTML5 history, for example), and so it's better that the
    base URL value is re-calculated whenever it's needed instead of caching the
    initial value.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48717278
  15. Set the aria label on the palette root element instead of setting it …

    nanaze committed Jul 9, 2013
    …on the inner table element so that cells are verbalized when the control is focused. Also remove hardcoded element names and aria roles by their goog.dom.TagName and goog.a11y.aria.Role equivalents.
    
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48707676
  16. Simplify IE capture simulation:

    nanaze committed Jul 9, 2013
    * When capture simulation occurs, we now let the browser
    handles the bubble phase.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48705720
  17. Extracts a ListenerMap class from goog.events.EventTarget. The

    nanaze committed Jul 9, 2013
    plan is to reuse this code from goog.events.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48702951
  18. Run genjsdeps over closure/datasource.

    nanaze committed Jul 9, 2013
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48686090
  19. Remove remaining_ count optimization in goog.events. This only

    nanaze committed Jul 9, 2013
    affects IE <=8 native listeners now. FWIW,
    goog.events.EventTarget moves away from this optimization and
    did not see any significant performance regression.
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48657760
  20. Fix coding convention in goog.debug.DebugWindow

    nanaze committed Jul 9, 2013
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48628960
  21. Simplify goog.structs.StringSet assuming that no new keys are added t…

    nanaze committed Jul 9, 2013
    …o Object.prototype.
    
    -------------
    Created by MOE: http://code.google.com/p/moe-java
    MOE_MIGRATED_REVID=48620801