Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debtor Id does not seem to be mandatory for pain 001 #58

Closed
lippertto opened this issue Nov 20, 2023 · 4 comments · Fixed by #60
Closed

Debtor Id does not seem to be mandatory for pain 001 #58

lippertto opened this issue Nov 20, 2023 · 4 comments · Fixed by #60

Comments

@lippertto
Copy link
Contributor

Hello,
I am trying to generate an xml file for a sepa transfer.
I get the message that debtorId is invalid, which is true because I do not set a debtor id.
From what I read in the documentation of the pain format, the debtorId is not required for transfer xml files.

If you agree, I would like to submit a patch to remove the check when it is a transfer.

The patch would modify the validate() function for SepaPaymentInfo

assert_cid(this[pullFrom + 'Id'], pullFrom + 'Id');

@dhrp
Copy link

dhrp commented Nov 24, 2023

Yes, additionally; what I have found is that the validation fails for (all) Dutch bank IBANs I have tried, the empty string and anything else, except for german iBAN's. It would like to see this be an optional field. -- Additionally; I noticed in the 003 document generated the ID doesn't even show...

@lippertto
Copy link
Contributor Author

Hello @dhrp,

I am working on including the id in both formats (001 and 003)

Just to make sure: did you put IBANs or Creditor Ids into the field? Creditor Ids have a different format from IBANs. There is a German Wikipedia article on this, but I did not see a Dutch one. But maybe Deepl can help you to translate it.

If you put Dutch Creditor Ids into the field and the validation failed, can you give me an example, so that I can reproduce the behavior?

Best, Tobias

@dhrp
Copy link

dhrp commented Nov 25, 2023

Thank you for your message @lippertto. From what I now can find I understand that there is such a thing.. 😀 In NL based on the chamber of commerce number.

However, in what I can find it is only required for a 001 direct debit (draft money from others) file, and not for a payment batch file. Can we make the field optional in a 003 batch payment file?

Now I know how to calculate my number I can do it, but our banks' website says you find the number on the direct debit contract. Which we don't have and don't need.

And just to be superfluously clear, we also don't need it for the people we pay to, as these private individuals do not have one.

@dhrp
Copy link

dhrp commented Nov 25, 2023

Ah. Haha. Noticed you already made it optional. Thanks!

kewisch pushed a commit that referenced this issue Nov 28, 2023
Also: Actually include the creditor/debitor ids when they are set

Fixes #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants