New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to electron. try affinity flag #12210
Conversation
@@ -15,7 +15,12 @@ const desktopPath = (...args) => path.join(__dirname, ...args) | |||
const copySyncFolder = (src, target, onlyExts) => { | |||
const srcRoot = desktopPath(src) | |||
const dstRoot = desktopPath(target) | |||
const files = klawSync(srcRoot, {filter: item => onlyExts.includes(path.extname(item.path))}) | |||
const files = klawSync(srcRoot, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
klaw passes the folders to us so if we reject it it won't keep going down
const comment: string = argv.comment || '' | ||
// $FlowIssue // flow-typed libdef is pretty weak, thinks this might be a boolean | ||
const outDir: string = argv.outDir || '' | ||
const shouldBuildAnArch: string = (argv.arch: any) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets just cast instead of flowissue
dir: desktopPath('./build'), | ||
electronVersion: 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flow doesn't like us assigning a var later to a key that doesn't exist
@@ -173,15 +182,16 @@ function pack(plat, arch, cb) { | |||
} | |||
} | |||
|
|||
packager(opts, cb) | |||
return packager(opts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we get deprecation warnings if we don't use the promise version
@oconnor663 |
@chrisnojima it seems ok to me when I do a local build. |
has to be what is a production type build and not any kind of hot server etc |
Codecov Report
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 86.03% 85.94% -0.09%
==========================================
Files 1232 1200 -32
Lines 61490 61215 -275
==========================================
- Hits 52902 52614 -288
- Misses 8588 8601 +13
Continue to review full report at Codecov.
|
@keybase/react-hackers we can look at this while waiting on a windows build |
@zanderz when you have a chance can we test a windows build of this |
@zanderz lets prioritize this monday |
Sorry, forgot to mention that I built and sanity checked this for minute,
got a tracker popup, etc.
…On Fri, Jun 8, 2018, 10:40 AM chrisnojima ***@***.***> wrote:
@zanderz <https://github.com/zanderz> lets prioritize this monday
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12210 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA0ovYdk8gZJTh0Z0JgoWpbIIThkaGSSks5t6ozjgaJpZM4UbZib>
.
|
@keybase/react-hackers can someone review. i'm going to kick admin builds off this commit so we can play with it today |
@oconnor663 / @zanderz can you double check notifications work |
@keybase/react-hackers lets review this and get it in |
I'm guessing the insecure CSP warning is expected. |
thats only in dev |
@keybase/react-hackers bump |
I ran this branch for most of the morning with no issues, but that was with |
Better to make a test build with the bot
…On Mon, Jun 11, 2018 at 2:00 PM Adam Spooner ***@***.***> wrote:
I ran this branch for most of the morning with no issues, but that was
with hot-server and start-hot. Everything seems fine to me. Is that
enough to approve it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12210 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAfhU_sGXUGjktvwf7wRMr5Qjgi5eYQpks5t7rA8gaJpZM4UbZib>
.
|
How do I do that? |
Sorry, I have missing notifications with build https://prerelease.keybase.io/windows/Keybase_2.1.0-20180607094851%2B399affe0c6.386.exe, which I think is supposed to contain the windows fix. Still looking. |
building a new windows one off this branch now |
I'm not sure it's relevant, but I get this error when I set an exploding message time: |
unrelated, i just merged master back in so that kind of stuff won't show up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on macOS!
Notifications work with https://prerelease.keybase.io/windows/Keybase_2.1.0-20180611142735%2B918d49f71.386.exe, LGTM |
k i'm merging |
This updates electron to 2.0.2 and updates the packager and some packager deps.
This also turns on the affinity flag: electron/electron#11501 which reduces the overhead when we have multiple remote windows going