New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use service temp file for implementing share action CORE-9060 #14085

Merged
merged 3 commits into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@mmaxim
Member

mmaxim commented Oct 4, 2018

@keybase/react-hackers

This does the same thing we did for 'Save' for attachments, uses the service to create the temp file before sharing it. Also cleans up some of this code.

@mmaxim mmaxim merged commit 5012ec4 into master Oct 4, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@mmaxim mmaxim deleted the mike/CORE-9060 branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment