New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower wait time for service check #14097

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@mmaxim
Member

mmaxim commented Oct 5, 2018

These wait times guarantee we sit around for 900ms on every startup, we can lower it and likely be fine.

@mmaxim mmaxim requested a review from maxtaco Oct 5, 2018

@maxtaco

Does the total amount of time we are willing to wait stay the same, but you are just changing the polling interval? It might be tuned the way it is to handle machine startups, where everything is competing for cores.

@mmaxim

This comment has been minimized.

Show comment
Hide comment
@mmaxim

mmaxim Oct 5, 2018

Member

It always wait the polling interval before doing anything, so we are stuck here for 900ms every time. You think checking every 100ms is too aggressive at startup? Doesn't seem like it to me.

Member

mmaxim commented Oct 5, 2018

It always wait the polling interval before doing anything, so we are stuck here for 900ms every time. You think checking every 100ms is too aggressive at startup? Doesn't seem like it to me.

@maxtaco

maxtaco approved these changes Oct 5, 2018

@mmaxim mmaxim merged commit 9baaede into master Oct 5, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@mmaxim mmaxim deleted the mike/CORE-9042 branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment