New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more chat permanent errors for missing keys CORE-9134 #14198

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
2 participants
@mmaxim
Member

mmaxim commented Oct 11, 2018

This can happen in some bizarre upgrade scenarios, so let's not error out the whole thread with a "transient" error and label these key errors as permanent.

@mmaxim mmaxim requested a review from joshblum Oct 11, 2018

@mmaxim

This comment has been minimized.

Show comment
Hide comment
@mmaxim

mmaxim Oct 11, 2018

Member

Addresses: #14139

Member

mmaxim commented Oct 11, 2018

Addresses: #14139

@mmaxim mmaxim merged commit 7d35a6e into master Oct 11, 2018

0 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests failed on CircleCI
Details

@mmaxim mmaxim deleted the mike/CORE-9134 branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment