New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use motw for chat attachment downloads #14527

Merged
merged 3 commits into from Nov 1, 2018

Conversation

Projects
None yet
2 participants
@mmaxim
Member

mmaxim commented Nov 1, 2018

Maybe you could try this to make sure it works @zanderz? Thanks!

@mmaxim mmaxim requested a review from zanderz Nov 1, 2018

@mmaxim

This comment has been minimized.

Member

mmaxim commented Nov 1, 2018

@zanderz

This comment has been minimized.

Contributor

zanderz commented Nov 1, 2018

Check!
image

@zanderz

zanderz approved these changes Nov 1, 2018

had to fix the fussy platform directive, but it works

@zanderz

This comment has been minimized.

Contributor

zanderz commented Nov 1, 2018

LGTM, still builds on Windows

@mmaxim mmaxim merged commit eb255cc into master Nov 1, 2018

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details

@mmaxim mmaxim deleted the mike/motw branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment